<html>
<head><meta charset="utf-8"><title>crater triage 1.49 · t-release · Zulip Chat Archive</title></head>
<h2>Stream: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/index.html">t-release</a></h2>
<h3>Topic: <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html">crater triage 1.49</a></h3>

<hr>

<base href="https://rust-lang.zulipchat.com">

<head><link href="https://rust-lang.github.io/zulip_archive/style.css" rel="stylesheet"></head>

<a name="219484793"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219484793" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219484793">(Dec 10 2020 at 15:11)</a>:</h4>
<p>ok -- so the issue <a href="https://github.com/rust-lang/rust/issues/79501">#79501</a> has the links</p>



<a name="219485043"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219485043" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219485043">(Dec 10 2020 at 15:12)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/index.html">https://crater-reports.s3.amazonaws.com/beta-1.49-1/index.html</a> is the one I'd start with</p>



<a name="219485191"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219485191" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219485191">(Dec 10 2020 at 15:13)</a>:</h4>
<p>what you want is the "regressed: root results" link</p>



<a name="219485218"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219485218" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219485218">(Dec 10 2020 at 15:13)</a>:</h4>
<p>for each of those, what I usually do is try to find an existing issue</p>



<a name="219485541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219485541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219485541">(Dec 10 2020 at 15:16)</a>:</h4>
<p>unfotunately github's search is usually pretty bad so this doesn't always work, and you shouldn't limit to just the ones tagged as beta regressions</p>



<a name="219486387"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486387" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486387">(Dec 10 2020 at 15:21)</a>:</h4>
<p>let me file one for the first issue so that you can get a sense</p>



<a name="219486623"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486623" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486623">(Dec 10 2020 at 15:23)</a>:</h4>
<p>ok, so I filed <a href="https://github.com/rust-lang/rust/issues/79902">https://github.com/rust-lang/rust/issues/79902</a></p>



<a name="219486680"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486680" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486680">(Dec 10 2020 at 15:23)</a>:</h4>
<p>if you dump issue links here I can milestone them as well</p>



<a name="219486704"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486704" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486704">(Dec 10 2020 at 15:23)</a>:</h4>
<p>but for now my recommendation is that one person at a time does this</p>



<a name="219486740"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486740" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486740">(Dec 10 2020 at 15:24)</a>:</h4>
<p>and the goal is to try to file as few issues as possible, collapsing into the same issue for the same bug</p>



<a name="219486813"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486813" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486813">(Dec 10 2020 at 15:24)</a>:</h4>
<p>there's also a possibility of spurious errors on the test failures (not so much compiler errors)</p>



<a name="219486859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486859">(Dec 10 2020 at 15:24)</a>:</h4>
<p>it can be hard to tell there, so feel free to ask here or just stop before hitting them and I can triage them</p>



<a name="219486932"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219486932" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219486932">(Dec 10 2020 at 15:25)</a>:</h4>
<p>cc <span class="user-mention" data-user-id="224872">@Ryan Levick</span> <span class="user-mention" data-user-id="281739">@oliver</span> - hopefully this is helpful, maybe you can coordinate between the two of you when to get started</p>



<a name="219489458"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219489458" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219489458">(Dec 10 2020 at 15:40)</a>:</h4>
<p>please let me know by <time datetime="2020-12-10T18:00:00Z">2020-12-10T13:00:00-05:00</time> whether you can commit to doing this, and ideally by <time datetime="2020-12-10T22:00:00Z">2020-12-10T17:00:00-05:00</time> we'd have it as done as we're going to get it so I can finish if needed</p>



<a name="219489791"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219489791" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219489791">(Dec 10 2020 at 15:43)</a>:</h4>
<p>yes I can participate</p>



<a name="219491044"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219491044" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219491044">(Dec 10 2020 at 15:51)</a>:</h4>
<p>I can participate. I only have about 2 more hours of time for today though. <span class="user-mention" data-user-id="281739">@oliver</span> how do you want to split work?</p>



<a name="219491312"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219491312" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219491312">(Dec 10 2020 at 15:53)</a>:</h4>
<p>I can help with review and anything else you don't have bandwidth for</p>



<a name="219491662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219491662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219491662">(Dec 10 2020 at 15:55)</a>:</h4>
<p>Ok I'll start going through the logs. We can switch off maybe after 30-60 minutes?</p>



<a name="219491681"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219491681" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219491681">(Dec 10 2020 at 15:55)</a>:</h4>
<p>I'll post what I find here</p>



<a name="219493616"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219493616" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219493616">(Dec 10 2020 at 16:08)</a>:</h4>
<p>This <a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/marcianx.openmesh-rs-core/log.txt">one</a> is interesting.</p>
<div class="codehilite"><pre><span></span><code>[INFO] [stdout] error[E0277]: the trait bound `H: handle::ItemHandle` is not satisfied
[INFO] [stdout]    --&gt; src/property/property.rs:119:14
[INFO] [stdout]     |
[INFO] [stdout] 119 |         self.clone_as_trait()
[INFO] [stdout]     |              ^^^^^^^^^^^^^^ the trait `handle::ItemHandle` is not implemented for `H`
[INFO] [stdout]     |
[INFO] [stdout] help: consider restricting type parameter `H`
[INFO] [stdout]     |
[INFO] [stdout] 116 | impl&lt;H: handle::ItemHandle&gt; Clone for Box&lt;dyn ResizeableProperty&lt;Handle=H&gt;&gt;
[INFO] [stdout]     |       ^^^^^^^^^^^^^^^^^^^^
</code></pre></div>



<a name="219493705"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219493705" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219493705">(Dec 10 2020 at 16:08)</a>:</h4>
<p><code>ResizeablePropertyHandle::Handle</code> implements <code>handle::ItemHandle</code></p>



<a name="219494981"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219494981" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219494981">(Dec 10 2020 at 16:15)</a>:</h4>
<p>so not a compiler related regression probably</p>



<a name="219495059"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495059" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495059">(Dec 10 2020 at 16:16)</a>:</h4>
<p>No it definitely is. I confirmed that this compiles on 1.48 and not on beta</p>



<a name="219495206"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495206" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495206">(Dec 10 2020 at 16:17)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> I'm guessing that coming up with a MCVE is not necessary right?</p>



<a name="219495370"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495370" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495370">(Dec 10 2020 at 16:18)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> usually we just open an issue for each "group" of errors, linking to the relevant crater logs</p>



<a name="219495468"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495468" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495468">(Dec 10 2020 at 16:18)</a>:</h4>
<p>triaging crater is not really parallelizable and one person can do it at the time</p>



<a name="219495501"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495501" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495501">(Dec 10 2020 at 16:19)</a>:</h4>
<p>I'm guessing we can't just assume that each error that has the same error number is actually the same though</p>



<a name="219495515"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495515" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495515">(Dec 10 2020 at 16:19)</a>:</h4>
<p>while figuring out <em>why</em> it's wrong is easily parallelizable</p>



<a name="219495670"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495670" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495670">(Dec 10 2020 at 16:20)</a>:</h4>
<p>when I triaged crater back in the day I just went with intuition</p>



<a name="219495911"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219495911" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219495911">(Dec 10 2020 at 16:21)</a>:</h4>
<p>like, I could see all the "oh this trait bound is supposed to be valid but it's not" grouped together</p>



<a name="219496480"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219496480" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219496480">(Dec 10 2020 at 16:25)</a>:</h4>
<p><span class="user-mention" data-user-id="121055">@Pietro Albini</span> I updated the issue to include all those logs (I hit submit a bit too soon before).</p>



<a name="219496529"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219496529" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219496529">(Dec 10 2020 at 16:25)</a>:</h4>
<p>The example I included is the most straightforward one though</p>



<a name="219496964"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219496964" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219496964">(Dec 10 2020 at 16:28)</a>:</h4>
<p><span aria-label="thumbs up" class="emoji emoji-1f44d" role="img" title="thumbs up">:thumbs_up:</span></p>



<a name="219497002"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219497002" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219497002">(Dec 10 2020 at 16:28)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/79905">https://github.com/rust-lang/rust/issues/79905</a></p>



<a name="219497014"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219497014" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Pietro Albini <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219497014">(Dec 10 2020 at 16:28)</a>:</h4>
<p>I usually batch-created issues at the end, but updating the issue body on the fly is also good!</p>



<a name="219497038"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219497038" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219497038">(Dec 10 2020 at 16:28)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/79904">https://github.com/rust-lang/rust/issues/79904</a></p>



<a name="219497145"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219497145" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219497145">(Dec 10 2020 at 16:29)</a>:</h4>
<p><span class="user-mention silent" data-user-id="121055">Pietro Albini</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E49/near/219497014">said</a>:</p>
<blockquote>
<p>I usually batch-created issues at the end, but updating the issue body on the fly is also good!</p>
</blockquote>
<p>I think that'd stress me out too much. I like going one by one, but I hope my way isn't annyoing to anyone</p>



<a name="219497446"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219497446" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219497446">(Dec 10 2020 at 16:31)</a>:</h4>
<p>Any thoughts on if error 0271 is related to 0277 in these cases: <a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/actix-amqp-0.1.4/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/actix-amqp-0.1.4/log.txt</a></p>



<a name="219498212"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219498212" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219498212">(Dec 10 2020 at 16:36)</a>:</h4>
<p><span class="user-mention" data-user-id="281739">@oliver</span> <span class="user-mention" data-user-id="116122">@simulacrum</span> ^^</p>



<a name="219498226"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219498226" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219498226">(Dec 10 2020 at 16:36)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/79906">https://github.com/rust-lang/rust/issues/79906</a></p>



<a name="219498504"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219498504" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219498504">(Dec 10 2020 at 16:38)</a>:</h4>
<p>This wasn't an error before? <a href="https://github.com/mitrid-labs/mitrid-core/blob/e28f237ea52cf0421485a1082636d469db4528de/src/io/network/client/on_error.rs#L15-L16">https://github.com/mitrid-labs/mitrid-core/blob/e28f237ea52cf0421485a1082636d469db4528de/src/io/network/client/on_error.rs#L15-L16</a> This seems like it should have always been an error</p>



<a name="219498811"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219498811" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219498811">(Dec 10 2020 at 16:40)</a>:</h4>
<p>last one is probably: <a href="https://github.com/rust-lang/rust/pull/77015">https://github.com/rust-lang/rust/pull/77015</a></p>



<a name="219498925"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219498925" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219498925">(Dec 10 2020 at 16:41)</a>:</h4>
<p>Yep it seems like it. Should I make a comment on the PR just noting it only seemed to break one crate?</p>



<a name="219499102"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219499102" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> tm <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219499102">(Dec 10 2020 at 16:42)</a>:</h4>
<p>it is already mentioned as a regression <a href="https://github.com/rust-lang/rust/pull/77015#issuecomment-703711569">https://github.com/rust-lang/rust/pull/77015#issuecomment-703711569</a></p>



<a name="219499388"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219499388" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219499388">(Dec 10 2020 at 16:44)</a>:</h4>
<p>Ah ok, leaving alone then</p>



<a name="219499684"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219499684" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219499684">(Dec 10 2020 at 16:46)</a>:</h4>
<p>Ah shoot. <a href="https://github.com/rust-lang/rust/issues/79906">https://github.com/rust-lang/rust/issues/79906</a> is a duplicate of <a href="https://github.com/rust-lang/rust/issues/77713">https://github.com/rust-lang/rust/issues/77713</a></p>



<a name="219499762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219499762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219499762">(Dec 10 2020 at 16:46)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> Should I reference the already open issue and close or does it make sense to have a second issue labeled as a regression?</p>



<a name="219500142"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219500142" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219500142">(Dec 10 2020 at 16:49)</a>:</h4>
<p>Oh I see it's been nominated to revert this on beta:<a href="https://github.com/rust-lang/rust/pull/79903">https://github.com/rust-lang/rust/pull/79903</a></p>



<a name="219500171"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219500171" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219500171">(Dec 10 2020 at 16:49)</a>:</h4>
<p>Sorry for being a bit overzealous there</p>



<a name="219500502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219500502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219500502">(Dec 10 2020 at 16:51)</a>:</h4>
<p>I closed the regression issue and linked to the open issue and PR</p>



<a name="219500552"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219500552" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219500552">(Dec 10 2020 at 16:51)</a>:</h4>
<p>I find it can be hard to keep track with everything going on at once</p>



<a name="219500805"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219500805" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219500805">(Dec 10 2020 at 16:52)</a>:</h4>
<p><span class="user-mention" data-user-id="281739">@oliver</span> Let me back up and give you a summary of where I am. Then maybe you can take over for a while?</p>



<a name="219501015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501015">(Dec 10 2020 at 16:54)</a>:</h4>
<p>For sure but I'm just needing to dropping off for an hour right now<br>
so I'll look for your summary when I get back <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<a name="219501049"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501049" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501049">(Dec 10 2020 at 16:54)</a>:</h4>
<p>you should reference as a duplicate and make sure the issue is labeled, but we can keep just one</p>



<a name="219501066"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501066" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501066">(Dec 10 2020 at 16:54)</a>:</h4>
<p>(feel free to go in either order)</p>



<a name="219501092"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501092" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501092">(Dec 10 2020 at 16:54)</a>:</h4>
<p>i.e., keep either one</p>



<a name="219501099"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501099" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501099">(Dec 10 2020 at 16:54)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E49/near/219501049">said</a>:</p>
<blockquote>
<p>you should reference as a duplicate and make sure the issue is labeled, but we can keep just one</p>
</blockquote>
<p>Labeled as duplicate? How do I do that</p>



<a name="219501133"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501133" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501133">(Dec 10 2020 at 16:54)</a>:</h4>
<p>oh it's just like literally write that</p>



<a name="219501152"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501152" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501152">(Dec 10 2020 at 16:55)</a>:</h4>
<p>"closing as a duplicate of #xxx" or so</p>



<a name="219501165"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501165" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501165">(Dec 10 2020 at 16:55)</a>:</h4>
<p><a href="https://github.com/rust-lang/rust/issues/79906#issuecomment-742646740">https://github.com/rust-lang/rust/issues/79906#issuecomment-742646740</a> This good?</p>



<a name="219501323"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501323" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501323">(Dec 10 2020 at 16:56)</a>:</h4>
<p>perfect!</p>



<a name="219501901"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219501901" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219501901">(Dec 10 2020 at 17:00)</a>:</h4>
<p>Going in order of issues in <code>regressed: root</code> on <a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/index.html">https://crater-reports.s3.amazonaws.com/beta-1.49-1/index.html</a>:</p>
<ul>
<li>The first (the ICE) was opened by Mark: <a href="https://github.com/rust-lang/rust/issues/79902">https://github.com/rust-lang/rust/issues/79902</a></li>
<li>I've skipped the second group (E0271) for now (more on that in just a second</li>
<li>I then opened <a href="https://github.com/rust-lang/rust/issues/79904">an issue</a> for failing to see bounds on an associated type (E0277). I'm not sure if this issue is actually related to (E0271). I need some help figuring that out. </li>
<li>I then opened <a href="https://github.com/rust-lang/rust/issues/79905">an issue</a> for failing to infer a generic param (E0282).</li>
<li>I then opened <a href="https://github.com/rust-lang/rust/issues/79906">an issue</a> for build failure when using deny/warn after using forbid (E0453), but this was a duplicate of an existing issue (see the issue for a link to the original issue).</li>
<li>The issue (E0517) which rejects nonsencial attributes on enum variants is already <a href="https://github.com/rust-lang/rust/pull/77015">being tracked</a> and determined to not be a regression.</li>
</ul>



<a name="219502004"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219502004" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219502004">(Dec 10 2020 at 17:01)</a>:</h4>
<p><span class="user-mention" data-user-id="281739">@oliver</span> this is where I am right now. I'll let you know if I do any more. It would be helpful for you to get somewhat familiar with the issues before starting</p>



<a name="219502247"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219502247" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219502247">(Dec 10 2020 at 17:02)</a>:</h4>
<p>I think the E0271 would be good to mention on the E0277 issue as "maybe same"?</p>



<a name="219502308"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219502308" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219502308">(Dec 10 2020 at 17:03)</a>:</h4>
<p>it looks like they're failing with <em>both</em> errors</p>



<a name="219502349"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219502349" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219502349">(Dec 10 2020 at 17:03)</a>:</h4>
<p>so probably unclear cause</p>



<a name="219502461"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219502461" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219502461">(Dec 10 2020 at 17:04)</a>:</h4>
<p>I'll mention those errors and say they might be related</p>



<a name="219503970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219503970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219503970">(Dec 10 2020 at 17:15)</a>:</h4>
<p><span class="user-mention" data-user-id="116122">@simulacrum</span> can you look at the "build failed (unknown)". these all have to do with macro_rules but they seem unrelated. What are your thoughts?</p>



<a name="219504641"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219504641" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219504641">(Dec 10 2020 at 17:20)</a>:</h4>
<p>For the "test failed (unknown)" I'm not sure what to do for most of them. A lot of them look like legit test failures and we'd probably want to run the tests on them to see what's happening</p>



<a name="219505762"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219505762" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219505762">(Dec 10 2020 at 17:29)</a>:</h4>
<p>ok, I will take those on, don't have time now</p>



<a name="219505929"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219505929" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219505929">(Dec 10 2020 at 17:30)</a>:</h4>
<p>Ok please make notes about your process here if you can so we can learn <span aria-label="hearts" class="emoji emoji-2665" role="img" title="hearts">:hearts:</span></p>



<a name="219508240"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219508240" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219508240">(Dec 10 2020 at 17:46)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/ErickHdez96.tiger/log.txt">ErickHdez96.tiger</a> - const in macro fragment -- error: expected expression, found keyword <code>const</code>,  potentially related to <a href="https://github.com/rust-lang/rust/issues/78912">#78912</a></p>



<a name="219509269"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219509269" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219509269">(Dec 10 2020 at 17:54)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/hiratara.toy-linear-type-system/log.txt">hiratara.toy-linear-type-system</a> - recursion limit - <code>parse mode</code> defined here - potentially related: <a href="https://github.com/rust-lang/rust/commit/92bfa05b07090be1b3bf32af0c8947a0f0b387e8">https://github.com/rust-lang/rust/commit/92bfa05b07090be1b3bf32af0c8947a0f0b387e8</a>, <a href="https://github.com/rust-lang/rust/issues/76537">https://github.com/rust-lang/rust/issues/76537</a></p>



<a name="219510292"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219510292" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219510292">(Dec 10 2020 at 18:01)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/fourier-0.1.0/log.txt">fourier-0.1.0</a> - error: no rules expected the token <code>f32</code>, potentially related <a href="https://github.com/rust-lang/rust/issues/69604">https://github.com/rust-lang/rust/issues/69604</a></p>



<a name="219510685"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219510685" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219510685">(Dec 10 2020 at 18:04)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/sem-0.1.0/log.txt">sem-0.1.0</a> - error: missing fragment specifier - <a href="https://github.com/rust-lang/rust/issues/76605">https://github.com/rust-lang/rust/issues/76605</a></p>



<a name="219511087"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219511087" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219511087">(Dec 10 2020 at 18:07)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/1000teslas.tree_traversal/log.txt">1000teslas.tree_traversal</a> - stack overflow</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="w">    </span><span class="k">fn</span> <span class="nf">test_stack_to_queue</span><span class="p">(</span><span class="n">e</span>: <span class="nb">Box</span><span class="o">&lt;</span><span class="n">Expr</span><span class="o">&gt;</span><span class="p">)</span><span class="w"> </span>-&gt; <span class="kt">bool</span> <span class="p">{</span><span class="w"></span>
<span class="w">        </span><span class="kd">let</span><span class="w"> </span><span class="n">ss</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">traverse</span><span class="p">(</span><span class="n">e</span><span class="p">.</span><span class="n">clone</span><span class="p">());</span><span class="w"></span>
<span class="w">        </span><span class="kd">let</span><span class="w"> </span><span class="n">sq</span><span class="w"> </span><span class="o">=</span><span class="w"> </span><span class="n">bf_traverse</span><span class="p">(</span><span class="n">e</span><span class="p">);</span><span class="w"></span>
<span class="w">        </span><span class="n">stack_to_queue</span><span class="p">(</span><span class="o">&amp;</span><span class="n">ss</span><span class="p">)</span><span class="w"> </span><span class="o">==</span><span class="w"> </span><span class="n">sq</span><span class="w"></span>
<span class="w">    </span><span class="p">}</span><span class="w"></span>
</code></pre></div>
<p><a href="https://github.com/rust-lang/rust/issues/57633">https://github.com/rust-lang/rust/issues/57633</a></p>



<a name="219511905"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219511905" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219511905">(Dec 10 2020 at 18:14)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/Floppy.ruby-version-badger/log.txt">Floppy.ruby-version-badger</a> - equality assertion failed</p>
<div class="codehilite" data-code-language="Rust"><pre><span></span><code><span class="k">pub</span><span class="w"> </span><span class="k">fn</span> <span class="nf">port</span><span class="p">()</span><span class="w"> </span>-&gt; <span class="nb">String</span> <span class="p">{</span><span class="w"></span>
<span class="w">    </span><span class="n">env</span>::<span class="n">var</span><span class="p">(</span><span class="s">"PORT"</span><span class="p">).</span><span class="n">unwrap_or</span><span class="p">(</span><span class="s">"3000"</span><span class="p">.</span><span class="n">to_string</span><span class="p">())</span><span class="w"></span>
<span class="p">}</span><span class="w"></span>

<span class="cp">#[test]</span><span class="w"></span>
<span class="k">fn</span> <span class="nf">default_to_port_3k</span><span class="p">()</span><span class="w"> </span><span class="p">{</span><span class="w"></span>
<span class="n">assert_eq</span><span class="o">!</span><span class="p">(</span><span class="s">"3000"</span><span class="p">,</span><span class="w"> </span><span class="n">config</span>::<span class="n">port</span><span class="p">());</span><span class="w"> </span><span class="c1">// encounters "3030"</span>
<span class="p">}</span><span class="w"></span>
</code></pre></div>



<a name="219511971"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219511971" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219511971">(Dec 10 2020 at 18:14)</a>:</h4>
<p>That's all I can do right now</p>



<a name="219514541"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219514541" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219514541">(Dec 10 2020 at 18:33)</a>:</h4>
<p>filed <a href="https://github.com/rust-lang/rust/issues/79908">https://github.com/rust-lang/rust/issues/79908</a> for the macro changes (tiger, fourier)</p>



<a name="219514614"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219514614" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219514614">(Dec 10 2020 at 18:34)</a>:</h4>
<p>noted on <a href="https://github.com/rust-lang/rust/issues/76605">#76605</a> that a revert has not yet happened, pinged</p>



<a name="219514757"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219514757" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219514757">(Dec 10 2020 at 18:35)</a>:</h4>
<p>afaict, tree-traversal is not related to <a href="https://github.com/rust-lang/rust/issues/57633">#57633</a> and I am confused by the reference; that issue is both old and represents a lack of diagnostics</p>



<a name="219515520"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515520" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515520">(Dec 10 2020 at 18:40)</a>:</h4>
<p>filed <a href="https://github.com/rust-lang/rust/issues/79909">https://github.com/rust-lang/rust/issues/79909</a> for the tree traversal, I think I recall seeing a combine issue earlier so might be a re-regression or so</p>



<a name="219515546"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515546" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515546">(Dec 10 2020 at 18:40)</a>:</h4>
<p>(previous cycle that is)</p>



<a name="219515607"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515607" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515607">(Dec 10 2020 at 18:41)</a>:</h4>
<p>er, not for tree traversal</p>



<a name="219515651"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515651" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515651">(Dec 10 2020 at 18:41)</a>:</h4>
<p>for the toy linear type system</p>



<a name="219515750"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515750" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515750">(Dec 10 2020 at 18:42)</a>:</h4>
<p>tree traversal not filing an issue for, likely spurious - I generally ignore stack overflows, they're unlikely to be Rust-caused in some sense (or we can't do much about them)</p>



<a name="219515814"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515814" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515814">(Dec 10 2020 at 18:43)</a>:</h4>
<p>ruby version badger, skipping, default_to_port_3k tells me it's probably a network test and those are flaky on crater (we have too many occupied ports and such)</p>



<a name="219515859"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515859" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515859">(Dec 10 2020 at 18:43)</a>:</h4>
<p>apery rust - similar stack overflow, likely spurious</p>



<a name="219515989"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219515989" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219515989">(Dec 10 2020 at 18:44)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/Indy2222.vole/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/Indy2222.vole/log.txt</a> - not sure what's up but seems likely to be spurious, seems to be running something in CLI which might be hitting a conflict</p>



<a name="219516015"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516015" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516015">(Dec 10 2020 at 18:44)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/PicoJr.bswp-cli/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/PicoJr.bswp-cli/log.txt</a> - again, cli, broken pipe, fairly common spurious</p>



<a name="219516045"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516045" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516045">(Dec 10 2020 at 18:45)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/appaquet.extsort-rs/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/appaquet.extsort-rs/log.txt</a> is rustdoc crate loading, almost always spurious</p>



<a name="219516268"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516268" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516268">(Dec 10 2020 at 18:46)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/bes.google-datastore1-generated/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/bes.google-datastore1-generated/log.txt</a> seems strange</p>



<a name="219516285"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516285" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516285">(Dec 10 2020 at 18:46)</a>:</h4>
<p>going to try and take a look at source</p>



<a name="219516345"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516345" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516345">(Dec 10 2020 at 18:47)</a>:</h4>
<p>ah interesting</p>



<a name="219516352"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516352" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516352">(Dec 10 2020 at 18:47)</a>:</h4>
<p><a href="https://github.com/bes/google-datastore1-generated/blob/master/src/lib.rs#L1">https://github.com/bes/google-datastore1-generated/blob/master/src/lib.rs#L1</a></p>



<a name="219516361"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516361" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516361">(Dec 10 2020 at 18:47)</a>:</h4>
<p>ok, filing issue, could be a real regression</p>



<a name="219516517"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516517" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516517">(Dec 10 2020 at 18:49)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E49/near/219516045">said</a>:</p>
<blockquote>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/appaquet.extsort-rs/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/appaquet.extsort-rs/log.txt</a> is rustdoc crate loading, almost always spurious</p>
</blockquote>
<p>this seems like a bug in crater maybe? I don't know how else it would have a 1.48 cache</p>
<div class="codehilite"><pre><span></span><code>[INFO] [stdout] ---- readme_sect_example_line_9 stdout ----
[INFO] [stdout] error[E0514]: found crate `byteorder` compiled by an incompatible version of rustc
[INFO] [stdout]  --&gt; /tmp/rust-skepticzXLIMM/test.rs:3:1
[INFO] [stdout]   |
[INFO] [stdout] 3 | extern crate byteorder;
[INFO] [stdout]   | ^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]   |
[INFO] [stdout]   = help: please recompile that crate using this compiler (rustc 1.49.0-beta.2 (bd26e4e54 2020-11-24))
[INFO] [stdout]   = note: the following crate versions were found:
[INFO] [stdout]           crate `byteorder` compiled by rustc 1.48.0 (7eac88abb 2020-11-16): /opt/rustwide/target/debug/deps/libbyteorder-d8402bb412e981c6.rlib
</code></pre></div>



<a name="219516527"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516527" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516527">(Dec 10 2020 at 18:49)</a>:</h4>
<p>oh well, not so much bug</p>



<a name="219516537"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516537" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516537">(Dec 10 2020 at 18:49)</a>:</h4>
<p>just we run everything at the same time</p>



<a name="219516573"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516573" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516573">(Dec 10 2020 at 18:49)</a>:</h4>
<p>rust-skeptic has problems in general I imagine</p>



<a name="219516580"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516580" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516580">(Dec 10 2020 at 18:49)</a>:</h4>
<p>but yeah this is probably related to <a href="https://github.com/rust-lang/rust/issues/68427#issuecomment-578113028">https://github.com/rust-lang/rust/issues/68427#issuecomment-578113028</a> somehow</p>



<a name="219516620"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516620" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516620">(Dec 10 2020 at 18:50)</a>:</h4>
<p>doubtful</p>



<a name="219516683"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516683" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516683">(Dec 10 2020 at 18:50)</a>:</h4>
<p>I see these all the time though so not a regression!</p>



<a name="219516725"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516725" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516725">(Dec 10 2020 at 18:50)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/bwinton.timemoji/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/bwinton.timemoji/log.txt</a> - honestly, no idea, but seems unlikely to be caused by Rust changes, probably spurious test</p>



<a name="219516777"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516777" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516777">(Dec 10 2020 at 18:51)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/chrisrhayden.words_cli/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/chrisrhayden.words_cli/log.txt</a> - probably fs error due to parallel tests or crater constraints</p>



<a name="219516818"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516818" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516818">(Dec 10 2020 at 18:51)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/ctsrc.persistence/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/ctsrc.persistence/log.txt</a> - also suspecting fs error</p>



<a name="219516899"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516899" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516899">(Dec 10 2020 at 18:52)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/doy.matasano/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/doy.matasano/log.txt</a> - seems to be in a module called "crack" so perhaps has randomness, not noting</p>



<a name="219516946"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516946" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516946">(Dec 10 2020 at 18:52)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/fsyncd.serde-command-opts/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/fsyncd.serde-command-opts/log.txt</a> - possibly changed ordering of hashmap iteration?</p>



<a name="219516970"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219516970" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219516970">(Dec 10 2020 at 18:52)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/garbados.roll-rs/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/garbados.roll-rs/log.txt</a> - almost certainly randomness</p>



<a name="219517025"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517025" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517025">(Dec 10 2020 at 18:53)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/luoos.bitcoin_client/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/luoos.bitcoin_client/log.txt</a> - seems likely to be random or so? generally unlikely to be a rust bug</p>



<a name="219517074"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517074" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517074">(Dec 10 2020 at 18:53)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/mantal.expert_system/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/mantal.expert_system/log.txt</a> also seems like not likely a rust bug, just nondeterministic solving</p>



<a name="219517383"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517383" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517383">(Dec 10 2020 at 18:55)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/mhthies.cdecao/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/mhthies.cdecao/log.txt</a> - also feels plausibly randomness related? fixed course sounds... pathfinding</p>



<a name="219517470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517470">(Dec 10 2020 at 18:56)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/naomijub.genetic-labyrinth/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/naomijub.genetic-labyrinth/log.txt</a> - likely spurious, mutation</p>



<a name="219517502"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517502" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517502">(Dec 10 2020 at 18:56)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/nkzawa.fzq/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/nkzawa.fzq/log.txt</a> - broken pipe, io error, likely just crater env spurious</p>



<a name="219517662"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517662" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517662">(Dec 10 2020 at 18:57)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/nrlsk.alloy/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/nrlsk.alloy/log.txt</a> - huh, weird, but again percents sounds like it is doing some potentially nondeterministic computation</p>



<a name="219517719"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517719" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517719">(Dec 10 2020 at 18:58)</a>:</h4>
<p>(if you can't tell the bar for test failure being a rust regression is pretty high for me)</p>



<a name="219517749"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517749" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517749">(Dec 10 2020 at 18:58)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/platy.raft/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/platy.raft/log.txt</a> - consensus algorithms</p>



<a name="219517807"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219517807" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219517807">(Dec 10 2020 at 18:58)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/richardanaya.globals/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/richardanaya.globals/log.txt</a> - probably mutating global env, or something, unsurprising to see problems</p>



<a name="219518394"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518394" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518394">(Dec 10 2020 at 19:03)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/saresend.shack/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/saresend.shack/log.txt</a> - possibly interacting with other instances of itself?</p>



<a name="219518428"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518428" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518428">(Dec 10 2020 at 19:03)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/vspecky.neat-rs/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/vspecky.neat-rs/log.txt</a> - fitness, seems to be random</p>



<a name="219518466"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518466" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518466">(Dec 10 2020 at 19:03)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/zesterer.flume/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/gh/zesterer.flume/log.txt</a> - timeout, likely spurious</p>



<a name="219518494"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518494" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518494">(Dec 10 2020 at 19:03)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/actix_web_metrics_mw-0.3.1/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/actix_web_metrics_mw-0.3.1/log.txt</a> - http unlikely to work well</p>



<a name="219518522"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518522" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518522">(Dec 10 2020 at 19:04)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/auto-0.0.8/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/auto-0.0.8/log.txt</a> - seems likely to be another case of the rustdoc failure</p>



<a name="219518845"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219518845" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219518845">(Dec 10 2020 at 19:06)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/bfc-1.9.0/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/bfc-1.9.0/log.txt</a> - I'm seeing some tests with names like pointer out of range, so maybe testing UB?</p>



<a name="219519241"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219519241" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219519241">(Dec 10 2020 at 19:09)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/big_enum_set-0.2.0/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/big_enum_set-0.2.0/log.txt</a> - span change, but not really a problem</p>



<a name="219519318"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219519318" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219519318">(Dec 10 2020 at 19:10)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/bosun_emitter-1.2.0/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/bosun_emitter-1.2.0/log.txt</a> - feels likely to be network</p>



<a name="219519346"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219519346" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219519346">(Dec 10 2020 at 19:10)</a>:</h4>
<p><a href="https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/crossbeam-channel-0.5.0/log.txt">https://crater-reports.s3.amazonaws.com/beta-1.49-1/beta-2020-11-26/reg/crossbeam-channel-0.5.0/log.txt</a> - seems likely to be spurious</p>



<a name="219519579"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219519579" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219519579">(Dec 10 2020 at 19:12)</a>:</h4>
<p>going to stop there so I can get through the rest quickly, but will flag anything I actually take action on</p>



<a name="219520516"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219520516" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219520516">(Dec 10 2020 at 19:20)</a>:</h4>
<p>ok didn't find any new things but added several rustdoc regression examples to that bug</p>



<a name="219520558"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219520558" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219520558">(Dec 10 2020 at 19:20)</a>:</h4>
<p>I will take a look at rustdoc's list later I guess, but I don't expect anything new in there, it's usually just more of the same</p>



<a name="219520576"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219520576" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219520576">(Dec 10 2020 at 19:20)</a>:</h4>
<p>(since rustdoc is almost a rust compiler)</p>



<a name="219522223"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219522223" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219522223">(Dec 10 2020 at 19:30)</a>:</h4>
<p>if you can look at intra-doc link errors or doctest errors that would be super helpful</p>



<a name="219522238"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219522238" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> Joshua Nelson <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219522238">(Dec 10 2020 at 19:30)</a>:</h4>
<p>but yeah I would expect most of the rest to be the same</p>



<a name="219534496"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219534496" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> oliver <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219534496">(Dec 10 2020 at 21:11)</a>:</h4>
<p><span class="user-mention silent" data-user-id="116122">simulacrum</span> <a href="#narrow/stream/241545-t-release/topic/crater.20triage.201.2E49/near/219520516">said</a>:</p>
<blockquote>
<p>ok didn't find any new things but added several rustdoc regression examples to that bug</p>
</blockquote>
<p>that's a cool outcome, thanks for outlining your criteria looking at these</p>



<a name="219540470"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219540470" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219540470">(Dec 10 2020 at 22:05)</a>:</h4>
<p>Awesome! This was very informative. I’d like to help out with this again next time.</p>



<a name="219541492"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219541492" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219541492">(Dec 10 2020 at 22:13)</a>:</h4>
<p>Do backport PRs like <a href="https://github.com/rust-lang/rust/pull/79903">this one</a> need any labels to ensure they’re not missed?</p>



<a name="219542341"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219542341" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219542341">(Dec 10 2020 at 22:20)</a>:</h4>
<p><span class="user-mention" data-user-id="224872">@Ryan Levick</span> so I usually open and r+ such PRs immediately</p>



<a name="219542347"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219542347" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219542347">(Dec 10 2020 at 22:20)</a>:</h4>
<p>you'll note it is targeting beta</p>



<a name="219542360"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219542360" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> simulacrum <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219542360">(Dec 10 2020 at 22:21)</a>:</h4>
<p>so there's not really any need for anyone else to look at it :)</p>



<a name="219542735"></a>
<h4><a href="https://rust-lang.zulipchat.com#narrow/stream/241545-t-release/topic/crater%20triage%201.49/near/219542735" class="zl"><img src="https://rust-lang.github.io/zulip_archive/assets/img/zulip.svg" alt="view this post on Zulip" style="width:20px;height:20px;"></a> rylev <a href="https://rust-lang.github.io/zulip_archive/stream/241545-t-release/topic/crater.20triage.201.2E49.html#219542735">(Dec 10 2020 at 22:24)</a>:</h4>
<p>Makes sense. I missed the r+. <span aria-label="+1" class="emoji emoji-1f44d" role="img" title="+1">:+1:</span></p>



<hr><p>Last updated: Aug 07 2021 at 22:04 UTC</p>
</html>